Reload cart totals when cart data changes#18700
Merged
magento-engcom-team merged 4 commits intomagento:2.3-developfrom Oct 31, 2018
Merged
Reload cart totals when cart data changes#18700magento-engcom-team merged 4 commits intomagento:2.3-developfrom
magento-engcom-team merged 4 commits intomagento:2.3-developfrom
Conversation
Contributor
|
Hi @tdgroot. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
VladimirZaets
approved these changes
Oct 19, 2018
Contributor
|
Hi @VladimirZaets, thank you for the review. |
Contributor
|
Hi @tdgroot. Thank you for your contribution. |
This was referenced Nov 1, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Dec 3, 2020
…ts/{cart_id}/totals-information endpoint
- Reverted #18700 PR that causes redundant calls of totals-information web-api
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
When cart data changes on cart view, the totals need to be reloaded. For example, when the qty changes, the totals of the cart data change as well.
This normally doesn't happen in default Magento, because cart mutations reload the entire page. I stumbled upon this problem when creating an extension that allows the customer to change qty without reloading the page.
Manual testing scenarios (*)
I can't really provide steps to reproduce my situation, because core Magento doesn't do javascript cart mutations on the cart view. But, when adding items to cart, the totals should be rendered properly. This change shouldn't affect the usual totals estimation. So here you go:
Contribution checklist (*)